You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#358. Change a Warn message to Debug so the spam will stop. Imo opinion this is probably not the best way to fix this, bc as a third party user if I set that error_msg pointer to null then i'm telling the code that I don't care about any string data, I just want the bool return and i'll take it from there. This still logs a message but at least it's debug and most users won't see it but developers can still see it if they set the log level to debug. If this is acceptable can we please backport to foxy?
I don't fully understand what that change does that you linked there. I can't imagine a case though where you couldn't be able to completely suppress console output from canTransform or lookupTransform. From the users standpoint, the thing returns true/false which is all probably 99.9% of callers of this care about. It's all topic based so I can just while(!canTransform) and wait for it to become available and if it doesn't then false tells me it didn't show up so a user gets to decide how they want to handle that. The only use case for any console output here is for debugging if there's a problem in which case the 3rd party user shouldn't be concerned about that and the user shouldn't have to take any additional action to prevent spam. I think it's even worse though bc, at least in my experience, I can't debug my code with this stuff in there bc the spam from this function prevents me from seeing any console output messages from the code that i'm actually interested in debugging. So me(and everybody else at my company) has to go into our code, find and comment out nodes that use canTransform or lookupTransform so when we run our stack we have a chance to see our console output. Feel free to close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #358. Change a Warn message to Debug so the spam will stop. Imo opinion this is probably not the best way to fix this, bc as a third party user if I set that
error_msgpointer tonullthen i'm telling the code that I don't care about any string data, I just want theboolreturn and i'll take it from there. This still logs a message but at least it's debug and most users won't see it but developers can still see it if they set the log level to debug. If this is acceptable can we please backport tofoxy?